From 96bde3c36230c382f0b818f0af290a5352d0325b Mon Sep 17 00:00:00 2001
From: perro <hi@perrotuerto.blog>
Date: Mon, 27 Feb 2023 13:46:03 -0800
Subject: [PATCH] Ejercicio 5a

---
 exercises/ex05/ex05a.py | 190 ++++++++++++++++++++++++++++++----------
 1 file changed, 144 insertions(+), 46 deletions(-)

diff --git a/exercises/ex05/ex05a.py b/exercises/ex05/ex05a.py
index d6f16f5..877c72d 100644
--- a/exercises/ex05/ex05a.py
+++ b/exercises/ex05/ex05a.py
@@ -1,52 +1,150 @@
-test1 = {
-    "1h": "bking",
-    "6c": "wqueen",
-    "2g": "bbishop",
-    "5h": "bqueen",
-    "3e": "wking",
-}
-test2 = {
-    "9h": "bking",
-}
-test3 = {
-    "1r": "bking",
-}
-test4 = {
-    "8h": "cking",
-}
-test5 = {
-    "8h": "wring",
-}
-test6 = {
-    "8h": "wking",
-    "7h": "wking",
-}
-test7 = None
+import sys
+
+tests = [
+    # Valid
+    {
+        "1h": "bking",
+        "6c": "wqueen",
+        "2g": "bbishop",
+        "5h": "bqueen",
+        "3e": "wking",
+    },
+    # Invalid: Illegal total amount of pieces
+    {
+        "1a": "wrook",
+        "1b": "wknight",
+        "1c": "wbishop",
+        "1d": "wqueen",
+        "1e": "wking",
+        "1f": "wbishop",
+        "1g": "wknight",
+        "1h": "wrook",
+        "2a": "wpawn",
+        "2b": "wpawn",
+        "2c": "wpawn",
+        "2d": "wpawn",
+        "2e": "wpawn",
+        "2f": "wpawn",
+        "2g": "wpawn",
+        "2h": "wpawn",
+        "3a": "wrook",
+    },
+    # Invalid: Illegal amount of pieces
+    {
+        "8h": "wking",
+        "7h": "wking",
+    },
+    # Invalid: Illegal position length
+    {
+        "9": "bking",
+    },
+    # Invalid: Illegal position length
+    {
+        "9hh": "bking",
+    },
+    # Invalid: Illegal tile number
+    {
+        "9h": "bking",
+    },
+    # Invalid: Illegal tile letter
+    {
+        "1r": "bking",
+    },
+    # Invalid: Illegal player color
+    {
+        "8h": "cking",
+    },
+    # Invalid: Illegal piece name
+    {
+        "8h": "wring",
+    },
+    # Invalid: Illegal piece data type
+    {
+        "8h": None,
+    },
+    # Invalid: Illegal board data type
+    None,
+]
+
+
+def invalidAmount(name, present, expected):
+    err = f"AmountError: total {name}"
+    return f"{err}; total == {present}, expected: <= {expected}"
+
+
+def invalidPos(name, pos, present, expected):
+    err = f"PositionError: {name} '{pos}'"
+    return f"{err}; length == {present}, expected: {expected}"
+
+
+def invalidPiece(name, color_piece, present, expected):
+    err = f"PieceError: {name} '{color_piece}'"
+    return f"{err}; {name} == {present}, expected: {expected}"
+
+
+def invalidType(name, present, expected):
+    err = f"TypeError: {name} type"
+    return False, f"{err}; type == {present}, expected: {expected}"
+
+
+def isValidPos(pos):
+    if len(pos) != 2:
+        return invalidPos("length", pos, len(pos), 2)
+    number, letter = pos[0], pos[1]
+    if number not in "12345678":
+        return invalidPos("number", pos, number, "1-8")
+    if letter not in "abcdefgh":
+        return invalidPos("letter", pos, letter, "a-h")
+
+
+def isValidPiece(color_piece):
+    pieces = "pawn knight bishop rook queen king".split()
+    color, piece = color_piece[0], color_piece[1:]
+    if color not in "bw":
+        return invalidPiece("color", color_piece, color, "w | b")
+    if piece not in pieces:
+        return invalidPiece("piece", color_piece, piece, " | ".join(pieces))
+
+
+def isValidAmount(player):
+    totals = {
+        "all": 16,
+        "pawn": 8,
+        "king": 1,
+    }
+    total = 0
+    for key, val in totals.items():
+        if key in player.keys() and player[key] > val:
+            return invalidAmount(f"'{key}'", player[key], val)
+    for val in player.values():
+        total += val
+        if total > totals["all"]:
+            return invalidAmount("pieces", total, totals["all"])
 
 
 def isValidChessBoard(board):
-    pieces = "pawn knight bishop rook queen king".split()
-    players = {"w": {}, "b": {}}
-    totals = {"pa": 8, "kn": 2, "bi": 2, "ro": 2, "qu": 1, "ki": 1}
+    players, valid, msg = {}, True, "Valid"
     if not isinstance(board, dict):
-        return False
-    for k, v in board.items():
-        if len(k) > 2 or k[0] not in "12345678" or k[1] not in "abcdefgh":
-            return False
-        if not isinstance(v, str) or v[0] not in "bw" or v[1:] not in pieces:
-            return False
-        players[v[0]].setdefault(v[1:3], 0)
-        players[v[0]][v[1:3]] += 1
-        # TODO
-        for board in players.values():
-            if board != totals:
-                return False
-    return True
+        return invalidType("board", type(board), type({}))
+    for pos, piece in board.items():
+        if not isinstance(piece, str):
+            return invalidType("piece", type(piece), type(""))
+        players.setdefault(piece[0], {})
+        player = players[piece[0]]
+        player.setdefault(piece[1:], 0)
+        player[piece[1:]] += 1
+        checks = [isValidPos(pos), isValidPiece(piece), isValidAmount(player)]
+        for check in checks:
+            if check is not None:
+                valid, msg = False, check
+                break
+    return valid, msg
 
 
-for test in [test1, test2, test3, test4, test5, test6, test7]:
-    print(f"Testing board '{test}': ", end="")
-    if isValidChessBoard(test):
-        print("Valid")
-    else:
-        print("Invalid")
+valid = True
+for test in tests:
+    print(f"Testing board '{test}': ")
+    valid, msg = isValidChessBoard(test)
+    print("=>", msg)
+if not valid:
+    sys.exit(1)